[AMD/ROCm] qwen3.5 fp8 mi355x SGL performance update#995
[AMD/ROCm] qwen3.5 fp8 mi355x SGL performance update#995
Conversation
Signed-off-by: seungrokj <seungrok.jung@amd.com>
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you |
1 similar comment
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you |
Signed-off-by: seungrokj <seungrok.jung@amd.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| description: | ||
| - "Qwen3.5 fp8 mi355x performance update" | ||
| - "Relevant Issue: https://github.com/sgl-project/sglang/issues/19633" | ||
| pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/995 |
There was a problem hiding this comment.
🟡 The new changelog entry uses a placeholder PR link pull/9xx instead of the actual PR number. Since this PR is #995, the link should be https://github.com/SemiAnalysisAI/InferenceX/pull/995. Please update perf-changelog.yaml line 1244 to fix the broken link before merging.
Extended reasoning...
The changelog entry added by this PR (perf-changelog.yaml, last entry) sets pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/9xx. This is clearly a placeholder that was never replaced with the actual PR number.
The specific code path is straightforward: the diff shows the new entry was added at the bottom of perf-changelog.yaml with pull/9xx as the PR link. This PR is #995 based on the PR metadata, so the correct value would be pull/995.
Existing placeholder entries in the file consistently use the pattern pull/XXX (all uppercase letters) when the PR number is unknown at write time — for example, entries for kimik2.5-int4-mi300x-vllm, glm5-fp8-mi355x-sglang, minimaxm2.5-fp8-h200-vllm, qwen3.5-bf16-mi325x-sglang, and qwen3.5-fp8-mi325x-sglang all use pull/XXX. The pull/9xx pattern is a non-standard variant suggesting the author partially began filling in the number (starting with the known digit 9) but left it incomplete.
The impact is a broken/invalid hyperlink in the changelog. Anyone clicking the link to trace the history of the qwen3.5-fp8-mi355x-sglang configuration change would land on a 404 page instead of this PR.
The fix is a one-character change: replace pull/9xx with pull/995 on line 1244 of perf-changelog.yaml.
Step-by-step proof:
- PR metadata confirms this is PR [AMD/ROCm] qwen3.5 fp8 mi355x SGL performance update #995 (
<pr number="995">) - The diff shows the addition of
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/9xx - Navigating to
https://github.com/SemiAnalysisAI/InferenceX/pull/9xxwould 404 since9xxis not a valid PR number - The correct URL
https://github.com/SemiAnalysisAI/InferenceX/pull/995would point to this very PR
Signed-off-by: seungrokj <seungrok.jung@amd.com>
Signed-off-by: seungrokj <seungrok.jung@amd.com>
Signed-off-by: seungrokj <seungrok.jung@amd.com>
1 participant
Need more testing.
This PR supersedes this previous PR #910
Regards,
Seungrok